This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Generate doc file URL via LSP (to fix it for Windows) #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
replaced "file://" hardcode with LSP normalizer, this fixes both three slashes for windows and replaces backslashes with forward slash (as mentioned in haskell/vscode-haskell/pull/270) and makes it work for Windows Windows, VS Code + ghcide via Haskell (HLS) 1.0.1 works fine now:
|
DunetsNM
changed the title
wz1000
approved these changes
Aug 29, 2020
|
Thanks you, and apologies for the long delay in merging your PR! |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…#721) * use three slashes in doc file URLs to fix it for Windows * generate normalized doc file URL using LSP
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…#721) * use three slashes in doc file URLs to fix it for Windows * generate normalized doc file URL using LSP
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…#721) * use three slashes in doc file URLs to fix it for Windows * generate normalized doc file URL using LSP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for haskell/haskell-language-server#247
Windows understands only file:/// but not file:// (at least it's true for VS Code)