This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Add a test case involving -fno-warn-missing-signatures #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, but I think a better way to achieve the same goal would be to strip out |
|
I recommend closing this since it should be fixed by #738. Thanks for bringing attention to this! |
pepeiborra
suggested changes
Sep 2, 2020
|
Ok cool, I confirmed that the problem is resolved in HEAD. |
zliu41
changed the title
pepeiborra
approved these changes
Sep 3, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…e#720) * Only enable non-fatal warnings * Revert the change since it has been taken care of in haskell/ghcide#738
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…e#720) * Only enable non-fatal warnings * Revert the change since it has been taken care of in haskell/ghcide#738
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
…e#720) * Only enable non-fatal warnings * Revert the change since it has been taken care of in haskell/ghcide#738
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to run ghcide on https://github.com/agda/agda, and the majority of the modules failed. What I observed was
Agda.cabaldeclares missing signatures as fatal (-Werror=missing-signatures)Lexer.hs(a generated file) has missing signatures, but it disables the warning by{-# OPTIONS_GHC -fno-warn-missing-signatures #-}.Lexer.hs, citing missing signatures.Lexer.hsis transitively imported by a lot of modules.This PR fixes it by only enabling non-fatal warnings in
DynFlags.