This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Fix Binary instance of Q to handle empty file paths #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann-da
approved these changes
Jul 24, 2020
ndmitchell
reviewed
Jul 27, 2020
| put (Q (k, fp)) = put (k, fp) | ||
| get = do | ||
| (k, fp) <- get | ||
| -- The `get` implementation of NormalizedFilePath |
There was a problem hiding this comment.
Could we not fix this upstream? Would be good to either have a link to the issue tracking it, or some more detailed explanation of why it's never possible to fix upstream.
There was a problem hiding this comment.
Upstream doesn’t want to allow empty filepaths since they’re technically not URLs (at least that was the result last time this came up). I did open haskell/lsp#249 but it doesn’t fix it since the conversion from filepaths to URIs doesn’t work on empty file paths so while it decodes the filepath correctly it cannot convert it.
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.