This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Use a global namecache to read .hie files
#677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
force-pushed
the
hiefile-namecache
branch
3 times, most recently
from
8b2570e to
b260708
Compare
cocreature
approved these changes
Jul 6, 2020
| @@ -0,0 +1,394 @@ | |||
| {- | |||
There was a problem hiding this comment.
I’m increasingly starting to wonder if GHC is the right location for the .hie files code. We seem to copy paste basically everything since we need to patch it. Hopefully, things will stabilize at some point 😞
There was a problem hiding this comment.
It's used by haddock, so there isn't much of an alternative at this point.
Unfortunately this will soon become worse, as I have a patch to backport .hie files to ghc-8.6
|
Needs rebasing. |
Co-authored-by: Matthew Pickering <[email protected]>
Since we started reusing `.hi` files, this exposes a bug where definitions aren't available since a bad source span from the `.hi` file gets put into the NameCache. We rectify by ensuring the span in the NameCache always matches the one from the `.hie` file. This has surfaced because an interaction between the commit which uses `.hi` instead of retypechecking and the change to use the shared global NameCache to read `.hie` files.
|
I found a bug introduced by this, fixed it and modified the tests to exercise this code path. See the commit message of 96d1f30 for an explanation. |
|
Thanks for the bugfix! |
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Use global NameCache for reading HIE files Co-authored-by: Matthew Pickering <[email protected]> * ignore hlint * redundant imports * Use hie files as source of truth for name source spans. Since we started reusing `.hi` files, this exposes a bug where definitions aren't available since a bad source span from the `.hi` file gets put into the NameCache. We rectify by ensuring the span in the NameCache always matches the one from the `.hie` file. This has surfaced because an interaction between the commit which uses `.hi` instead of retypechecking and the change to use the shared global NameCache to read `.hie` files. * Add test for missing definitions Co-authored-by: Matthew Pickering <[email protected]>
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Use global NameCache for reading HIE files Co-authored-by: Matthew Pickering <[email protected]> * ignore hlint * redundant imports * Use hie files as source of truth for name source spans. Since we started reusing `.hi` files, this exposes a bug where definitions aren't available since a bad source span from the `.hi` file gets put into the NameCache. We rectify by ensuring the span in the NameCache always matches the one from the `.hie` file. This has surfaced because an interaction between the commit which uses `.hi` instead of retypechecking and the change to use the shared global NameCache to read `.hie` files. * Add test for missing definitions Co-authored-by: Matthew Pickering <[email protected]>
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Use global NameCache for reading HIE files Co-authored-by: Matthew Pickering <[email protected]> * ignore hlint * redundant imports * Use hie files as source of truth for name source spans. Since we started reusing `.hi` files, this exposes a bug where definitions aren't available since a bad source span from the `.hi` file gets put into the NameCache. We rectify by ensuring the span in the NameCache always matches the one from the `.hie` file. This has surfaced because an interaction between the commit which uses `.hi` instead of retypechecking and the change to use the shared global NameCache to read `.hie` files. * Add test for missing definitions Co-authored-by: Matthew Pickering <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports this GHC MR in preparation for a larger role for
.hiefiles in ghcide.We now have a global shared
NameCachereferenced byShakeExtras, which we use to read.hiefiles.