This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
reviewed
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 2 comments
pepeiborra
force-pushed
the
GhcSession-alwaysRerun
branch
from
June 22, 2020 11:33
23b1776
to
2d9648f
Compare
Rebased |
cocreature
approved these changes
Jun 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Cache the results of loadSession until the components change * Track the cradle dependencies * hlint * Add cradle to watched files test * Add comment on sessionVersion field
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Cache the results of loadSession until the components change * Track the cradle dependencies * hlint * Add cradle to watched files test * Add comment on sessionVersion field
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Cache the results of loadSession until the components change * Track the cradle dependencies * hlint * Add cradle to watched files test * Add comment on sessionVersion field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
GhcSession
tracks the component dependencies, andGhcSessionIO
(no file) tracks the set of components. SinceGhcSession
has a dependency onGhcSessionIO
, this works out as intended: if the set of components changes, all the Ghc sessions become invalidated. Otherwise, a Ghc session is invalidated only when the component dependencies (e.g. the Cabal file) change.Another 10% perf improvement.
Fixes #619
Benchmarks where HEAD is this patch, upstream is the previous master:
Graphs here: https://github.com/pepeiborra/ghcide/tree/GhcSession-alwaysRerun-benchmarks/bench-hist