Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Canonicalize the locations in the cradle tests #628

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Jun 11, 2020

On macOS, the $TMPDIR folder leads to /var/blahblahblah, but this is canonicalized to /private/var/blahblahblah for reasons beyond my understanding. Either way, there were some test failures because of a mismatch between the two, so canonicalize the Uris inside the locations to fix this.

The error looked like:

simple-multi-test:                                         FAIL (13.67s)
test/exe/Main.hs:1312:
expected: Location {_uri = Uri {getUri = "file:///var/folders/zh/fqwj2cq95b7gbzs49fsq5drw0000gn/T/extra-dir-50174116387/a/A.hs"}, _range = Range {_start = Position {_line = 2, _character = 0}, _end = Position {_line = 2, _character = 3}}}
 but got: Location {_uri = Uri {getUri = "file:///private/var/folders/zh/fqwj2cq95b7gbzs49fsq5drw0000gn/T/extra-dir-50174116387/a/A.hs"}, _range = Range {_start = Position {_line = 2, _character = 0}, _end = Position {_line = 2, _character = 3}}}

On macOS, the $TMPDIR folder leads to /var/blahblahblah, but this is
canonicalized to /private/var/blahblahblah for reasons beyond my
understanding. Either way, there were some test failures because of a
mismatch between the two, so canonicalize the Uris inside the locations
to fix this
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cocreature cocreature merged commit 14e30e4 into haskell:master Jun 12, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
On macOS, the $TMPDIR folder leads to /var/blahblahblah, but this is
canonicalized to /private/var/blahblahblah for reasons beyond my
understanding. Either way, there were some test failures because of a
mismatch between the two, so canonicalize the Uris inside the locations
to fix this
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
On macOS, the $TMPDIR folder leads to /var/blahblahblah, but this is
canonicalized to /private/var/blahblahblah for reasons beyond my
understanding. Either way, there were some test failures because of a
mismatch between the two, so canonicalize the Uris inside the locations
to fix this
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
On macOS, the $TMPDIR folder leads to /var/blahblahblah, but this is
canonicalized to /private/var/blahblahblah for reasons beyond my
understanding. Either way, there were some test failures because of a
mismatch between the two, so canonicalize the Uris inside the locations
to fix this
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants