This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Fix a bug in getHiFileRule #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we rename these types as GetModIface and GetModIface_FromDisk so show their relationship more visibly? |
pepeiborra
force-pushed
the
fix-getHiFileRule
branch
from
125b459 to
bcfb9d7
Compare
Done! Thanks for the suggestion |
cocreature
approved these changes
Jun 12, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Fix bug in getHiFileRule * Renamed GetHiFile to GetModIfaceFromDisk for clarity
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Fix bug in getHiFileRule * Renamed GetHiFile to GetModIfaceFromDisk for clarity
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Fix bug in getHiFileRule * Renamed GetHiFile to GetModIfaceFromDisk for clarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #589 ghcide now errors out occassionally with
internal error - GetHiFile of file of interest.This is great! It uncovers a real bug in
getHiFileRule, although I'm not sure if the bug would have any user impact.The problem is that
getHiFileRulehas direct dependencies onGetHiFile, which is wrong for the reasons explained in the expanded comment.