Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Update to latest hie-bios #382

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Jan 27, 2020

Updates ghcide to use the latest hie-bios version 0.4.0

@digitalasset-cla
Copy link

digitalasset-cla commented Jan 27, 2020

CLA assistant check
All committers have signed the CLA.

@cocreature
Copy link
Collaborator

I tested this as part of #361 and it seemed to work fine.

@fendor fendor mentioned this pull request Jan 28, 2020
3 tasks
@fendor fendor force-pushed the wip/update-latest-bios branch 2 times, most recently from 70abb72 to f5af861 Compare February 3, 2020 13:14
@fendor fendor changed the title WIP: Update to latest hie-bios Update to latest hie-bios Feb 3, 2020
@fendor fendor force-pushed the wip/update-latest-bios branch 2 times, most recently from 6059827 to f70f688 Compare February 3, 2020 13:45
@fendor
Copy link
Collaborator Author

fendor commented Feb 3, 2020

What OS does CI run? E.g. I can not rely that it builds on windows only because CI is green, right?

@fendor fendor force-pushed the wip/update-latest-bios branch from f70f688 to 94ae500 Compare February 3, 2020 17:53
@cocreature
Copy link
Collaborator

CI only runs Linux but if hie-bios compiles on Windows in general I’m not too worried about that. We don’t have any windows-specific code in this part. And if you are worried about actually running rather than just compiling, our test suite isn’t going to be particularly helpful. We don’t test the hie-bios setup. All our tests just rely on base and not much else.

@fendor
Copy link
Collaborator Author

fendor commented Feb 3, 2020

I remember that I had to add an additional dependency for windows on hie. I will test it on my system later.

@fendor fendor requested review from cocreature and ndmitchell and removed request for cocreature February 3, 2020 21:33
@fendor
Copy link
Collaborator Author

fendor commented Feb 3, 2020

Tested to build stack84.yaml on windows and it succeeded.

exe/Main.hs Outdated Show resolved Hide resolved
exe/Main.hs Outdated Show resolved Hide resolved
@@ -3,6 +3,7 @@ packages:
- .
extra-deps:
- fuzzy-0.1.0.0
- hie-bios-0.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this will clash with my changes in #400 - but I'm happy to rebase after this lands.

@fendor fendor requested a review from ndmitchell February 3, 2020 21:56
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cocreature cocreature merged commit 1d04b09 into haskell:master Feb 4, 2020
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Update to latest hie-bios

* Remove explicit usage of type parameter Void from Cradle
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Update to latest hie-bios

* Remove explicit usage of type parameter Void from Cradle
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Update to latest hie-bios

* Remove explicit usage of type parameter Void from Cradle
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants