Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Code action to insert new definitions #309

Merged
merged 8 commits into from
Jan 13, 2020

Conversation

pepeiborra
Copy link
Collaborator

GHC error messages are quite awesome. If only there was a typed API ...

@pepeiborra pepeiborra force-pushed the introduceDefinition branch from e270839 to 55b290a Compare January 6, 2020 23:54
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! Some comments.

Maybe a similar action could be added for holes, additionally to filling the hole with existing definitions, ghcide could offer to fill it with a new definition. (Can be in a separate PR)

src/Development/IDE/LSP/CodeAction.hs Outdated Show resolved Hide resolved
src/Development/IDE/LSP/CodeAction.hs Outdated Show resolved Hide resolved
test/exe/Main.hs Outdated Show resolved Hide resolved
@pepeiborra pepeiborra force-pushed the introduceDefinition branch from ba008e3 to d074a39 Compare January 9, 2020 22:54
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with some minor comments, thank you!

src/Development/IDE/Types/Location.hs Outdated Show resolved Hide resolved
test/exe/Main.hs Outdated Show resolved Hide resolved
@jneira
Copy link
Member

jneira commented Jan 10, 2020

GHC error messages are quite awesome. If only there was a typed API ...

@pepeiborra some work in progress: https://github.com/bgamari/ghc-pretty-errors/pull/5/files 😄

Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@cocreature cocreature merged commit 789f403 into haskell:master Jan 13, 2020
pepeiborra added a commit to pepeiborra/ghcide that referenced this pull request Jan 19, 2020
* code action to insert new definitions
pepeiborra added a commit to pepeiborra/ghcide that referenced this pull request Feb 1, 2020
* code action to insert new definitions
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* code action to insert new definitions
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* code action to insert new definitions
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* code action to insert new definitions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants