-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
e270839
to
55b290a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! Some comments.
Maybe a similar action could be added for holes, additionally to filling the hole with existing definitions, ghcide could offer to fill it with a new definition. (Can be in a separate PR)
ba008e3
to
d074a39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great with some minor comments, thank you!
a2dace8
to
910a2b9
Compare
@pepeiborra some work in progress: https://github.com/bgamari/ghc-pretty-errors/pull/5/files 😄 |
Co-Authored-By: Moritz Kiefer <[email protected]>
910a2b9
to
dfb85f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
* code action to insert new definitions
* code action to insert new definitions
* code action to insert new definitions
* code action to insert new definitions
* code action to insert new definitions
GHC error messages are quite awesome. If only there was a typed API ...