Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Document symbols provider #293

Merged
merged 5 commits into from
Dec 31, 2019
Merged

Document symbols provider #293

merged 5 commits into from
Dec 31, 2019

Conversation

pepeiborra
Copy link
Collaborator

Low hanging fruit, worth doing as VS Code makes document outlines actually useful by adorning them with warnings and errors markers.

@pepeiborra pepeiborra force-pushed the outline branch 2 times, most recently from 7a967aa to 2ef8029 Compare December 29, 2019 19:32
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great!

Some small comments.

src/Development/IDE/LSP/Outline.hs Outdated Show resolved Hide resolved
src/Development/IDE/LSP/Outline.hs Outdated Show resolved Hide resolved
src/Development/IDE/LSP/Outline.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these!

@aherrmann-da aherrmann-da merged commit 5ca06a1 into haskell:master Dec 31, 2019
pepeiborra added a commit to pepeiborra/ghcide that referenced this pull request Jan 3, 2020
* Document symbols provider

* Compatibility with GHC 8.4

* Replace large number with more descriptive maxBound

Co-Authored-By: Andreas Herrmann <[email protected]>

* Use SkFunction for all Val Declarations

* Improve outlining of PatBind and FunBind

No longer relying on gfindtype

Co-authored-by: Andreas Herrmann <[email protected]>
pepeiborra added a commit to pepeiborra/ghcide that referenced this pull request Feb 1, 2020
* Document symbols provider

* Compatibility with GHC 8.4

* Replace large number with more descriptive maxBound

Co-Authored-By: Andreas Herrmann <[email protected]>

* Use SkFunction for all Val Declarations

* Improve outlining of PatBind and FunBind

No longer relying on gfindtype

Co-authored-by: Andreas Herrmann <[email protected]>
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Document symbols provider

* Compatibility with GHC 8.4

* Replace large number with more descriptive maxBound

Co-Authored-By: Andreas Herrmann <[email protected]>

* Use SkFunction for all Val Declarations

* Improve outlining of PatBind and FunBind

No longer relying on gfindtype

Co-authored-by: Andreas Herrmann <[email protected]>
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Document symbols provider

* Compatibility with GHC 8.4

* Replace large number with more descriptive maxBound

Co-Authored-By: Andreas Herrmann <[email protected]>

* Use SkFunction for all Val Declarations

* Improve outlining of PatBind and FunBind

No longer relying on gfindtype

Co-authored-by: Andreas Herrmann <[email protected]>
pepeiborra added a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Document symbols provider

* Compatibility with GHC 8.4

* Replace large number with more descriptive maxBound

Co-Authored-By: Andreas Herrmann <[email protected]>

* Use SkFunction for all Val Declarations

* Improve outlining of PatBind and FunBind

No longer relying on gfindtype

Co-authored-by: Andreas Herrmann <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants