Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Fix #246 #252

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Fix #246 #252

merged 3 commits into from
Dec 16, 2019

Conversation

jacg
Copy link
Contributor

@jacg jacg commented Dec 15, 2019

getTypeLHsBind returned a single span corresponding to the overall function
binding. The fix drills down into the individual matches and returns a span for
each of them.

Fixes #246.

jacg added 3 commits December 15, 2019 19:19
`getTypeLHsBind` returned a single span corresponding to the overall function
binding. The fix drills down into the individual matches and returns a span for
each of them.

Fixes #246.
@jacg jacg changed the title <Fix #246 Fix #246 Dec 15, 2019
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with one minor comment, thank you!

src/Development/IDE/Spans/Calculate.hs Show resolved Hide resolved
@cocreature cocreature merged commit 2523c21 into haskell:master Dec 16, 2019
@jacg jacg deleted the fix-246 branch December 16, 2019 09:33
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Fix haskell/ghcide#246

`getTypeLHsBind` returned a single span corresponding to the overall function
binding. The fix drills down into the individual matches and returns a span for
each of them.

Fixes haskell/ghcide#246.

* Make it work on GHC 8.8

* Cosmetics
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Fix haskell/ghcide#246

`getTypeLHsBind` returned a single span corresponding to the overall function
binding. The fix drills down into the individual matches and returns a span for
each of them.

Fixes haskell/ghcide#246.

* Make it work on GHC 8.8

* Cosmetics
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
* Fix haskell/ghcide#246

`getTypeLHsBind` returned a single span corresponding to the overall function
binding. The fix drills down into the individual matches and returns a span for
each of them.

Fixes haskell/ghcide#246.

* Make it work on GHC 8.8

* Cosmetics
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover only works for first clause in multi-equation function definition
2 participants