This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Fix horrible path normalisation issue #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cocreature
approved these changes
Dec 8, 2019
|
Would canonicalizeFilePath end up doing both these things, potentially more robustly? |
|
|
|
Good point! |
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why sometimes the path to the cradle is absolute and other times it's relative. Using Linux and direct cradles, happens both on Emacs and Code.
Because of this issue, ghcide v0.4 is broken for me on certain files both on personal projects and at work.