Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Commit

Permalink
Fix regression in getSpanInfoRule (#622)
Browse files Browse the repository at this point in the history
This rule used withstale dependencies prior to #457 and was changed to plain use
for no good reason, which makes hovers unavailable when a dependency doesn't
typecheck
  • Loading branch information
pepeiborra authored Jun 10, 2020
1 parent f766e55 commit e380aad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Development/IDE/Core/Rules.hs
Original file line number Diff line number Diff line change
Expand Up @@ -451,10 +451,10 @@ getSpanInfoRule =
#if MIN_GHC_API_VERSION(8,6,0) && !defined(GHC_LIB)
let parsedDeps = []
#else
parsedDeps <- uses_ GetParsedModule tdeps
parsedDeps <- mapMaybe (fmap fst) <$> usesWithStale GetParsedModule tdeps
#endif

ifaces <- uses_ GetModIface tdeps
ifaces <- mapMaybe (fmap fst) <$> usesWithStale GetModIface tdeps
(fileImports, _) <- use_ GetLocatedImports file
let imports = second (fmap artifactFilePath) <$> fileImports
x <- liftIO $ getSrcSpanInfos packageState imports tc parsedDeps (map hirModIface ifaces)
Expand Down

0 comments on commit e380aad

Please sign in to comment.