Skip to content

Conversation

@hasufell
Copy link
Member

Please read Github PR Conventions and then fill in one of these two templates.


Template Α: This PR modifies cabal behaviour

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • Manual QA notes have been included.
  • Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

Template Β: This PR does not modify cabal behaviour (documentation, tests, refactoring, etc.)

Include the following checklist in your PR:

@hasufell hasufell removed the request for review from andreabedini December 16, 2023 09:26
@Mikolaj Mikolaj added the merge me Tell Mergify Bot to merge label Dec 16, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Dec 16, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Dec 16, 2023

backport 3.10

✅ Backports have been created

@Mikolaj
Copy link
Member

Mikolaj commented Dec 16, 2023

I'm going to expedite the merge unless anybody objects. @hasufell suggests this should be backported, so we need to speed up things to get this on 3.10 branch before the 3.10.3. release.

@Mikolaj Mikolaj added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Dec 16, 2023
@mergify mergify bot merged commit e3fd74c into haskell:master Dec 16, 2023
mergify bot added a commit that referenced this pull request Dec 17, 2023
Relax upper bounds on filepath (backport #9523)
@Bodigrim
Copy link
Collaborator

I checked that it is safe to allow filepath-1.5 in the latest released packages for Cabal-syntax and Cabal:

cabal unpack Cabal-syntax && (cd Cabal-syntax-3.10.2.0 && cabal build -c 'filepath>=1.5' --allow-newer='Cabal-syntax:filepath')
cabal unpack Cabal && (cd Cabal-3.10.2.1 && cabal build -c 'filepath>=1.5' --allow-newer='Cabal-syntax:filepath,Cabal:filepath')

(There are no tests in these packages, so cabal build instead of cabal test)

@Mikolaj
Copy link
Member

Mikolaj commented Dec 21, 2023

@Bodigrim: thank you. I will bring this up in today's dev's meeting and, if there are no objections, I will make the Hackage revision to the latest versions of the two packages (or to more versions if that's what we decide, given that Julian requested "To do revisions for the last 3 versions that were shipped with GHC").

@Mikolaj
Copy link
Member

Mikolaj commented Dec 22, 2023

We have a new policy. The agreement in the meeting was to make the revision, exclusively to the versions our policy covers, despite not fully meeting the secondary prerequisites from the policy. I've revised both https://hackage.haskell.org/package/Cabal-3.10.2.1 and https://hackage.haskell.org/package/Cabal-syntax-3.10.2.0. Thank you Julian and Bodigrim again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants