Implement v2-outdated command #9373
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/v2-outdated
branch
7 times, most recently
from
c9ad027 to
4bd7f60
Compare
| toPackageVersionConstraint (Dependency name versionRange _) = | ||
| PackageVersionConstraint name (simplifyVersionRange versionRange) | ||
|
|
||
| genericPackageDependencies :: GenericPackageDescription -> [Dependency] |
Collaborator
There was a problem hiding this comment.
I wonder if we can preserve the structure of the conditionals when presenting the results to the user. E.g. we can map CondTree ConfVar [Dependency] component into CondTree ConfVar [OurResultForDependency] Library` and use that to form the final report.
erikd
force-pushed
the
erikd/v2-outdated
branch
3 times, most recently
from
342c092 to
6c083a9
Compare
erikd
force-pushed
the
erikd/v2-outdated
branch
from
6c083a9 to
48ccdf8
Compare
erikd
force-pushed
the
erikd/v2-outdated
branch
6 times, most recently
from
cc3602f to
598c651
Compare
erikd
force-pushed
the
erikd/v2-outdated
branch
from
a1ac243 to
a41517e
Compare
The `Cmd*,hs` naming scheme is usually reserved for v2 commands and this is a v1 command so renaming this to make way for a v2 version of this command. Since the `v2-outdated` command does everything the `v1` version of the command does, this `Outdated.hs` module should probably be removed.
erikd
force-pushed
the
erikd/v2-outdated
branch
from
a41517e to
1b7686e
Compare
Collaborator
|
This appears superseded by: Should we close this? |
Collaborator
|
We now have v2-outdated (#10878), so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a
v2-outdatedcommand which is simply thev2version of theoutdatedcommand.It does all the
v2style setup in order to extract aPackageVersionConstraintlist and then calls into the v1 version of the command for the logic and IO for the results.Include the following checklist in your PR:
Bonus points for added automated tests!
Note: The diff on the file
CmdOutput.hsis rather weird because this PR renamesCmsOutdated.hstoOutdated.hsand then creates a new fileCmdOutput.hs.QA Notes
v2-outdatedcommand should work in an old project directory layout (a single top level<package>.cabalfile) and a new project directory with just acabal.projectfile.