check: allow "haiku" as a valid OS string. #9048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `OSHaiku` identifier has been merged in haskell#9006, for a future 3.13 release. However, tools that rely on earlier versions of cabal -- such as hackage -- don't recognise "haiku" as a valid OS identifier. This allows packages with `os(haiku)` present to pass CI and be uploaded to hackage in the interim.
Contributor
Author
|
Corresponding PR to hackage: haskell/hackage-server#1221 |
2 tasks
Mikolaj
approved these changes
Jun 20, 2023
Member
Mikolaj
left a comment
Mikolaj
left a comment
There was a problem hiding this comment.
If only Hackage HQ approves of the change, IMHO we need this workaround in cabal ASAP to lessen the chance that, e.g., network contributors file cabal bug reports, because cabal complains about haiku in their local cabal check tests.
ulysses4ever
approved these changes
Jun 20, 2023
Collaborator
ulysses4ever
left a comment
ulysses4ever
left a comment
There was a problem hiding this comment.
It's not pretty but if it does the job...
Kleidukos
approved these changes
Jun 23, 2023
Kleidukos
added
merge me
mergify
bot
added
the
merge delay passed
Kleidukos
removed
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OSHaikuidentifier has been merged in #9006, for a future 3.12 release. However, tools that rely on earlier versions of cabal -- such as hackage -- don't recognise "haiku" as a valid OS identifier.This allows packages with
os(haiku)present to pass CI and be uploaded to hackage until hackage can eventually be upgraded to use cabal 3.12.Please include the following checklist in your PR:
Bonus points for added automated tests!