Skip to content

Return empty default when git fails (backport #8755) #9032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2023
Merged

Return empty default when git fails (backport #8755) #9032

merged 2 commits into from
Jun 18, 2023

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 17, 2023

This is an automatic backport of pull request #8755 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

BasLaa added 2 commits June 17, 2023 13:25
@BasLaa @mergify
Return empty default when git fails
9f9c84a 
Add maybe in guess functions

Adjust type in NonInteractive

Change unit tests

Fix whitespace

Abstract guessing and remove comments

Simplify guess functions

Return default for cabal init author and name when git fails

(cherry picked from commit 5073063)
@BasLaa @mergify
Fix switched name and email guess
84d0103 
(cherry picked from commit d85bf80)
@mergify mergify bot mentioned this pull request Jun 17, 2023
Merged
@mergify mergify bot added the backport label Jun 17, 2023
@Kleidukos Kleidukos added the merge me Tell Mergify Bot to merge label Jun 17, 2023
ffaf1
ffaf1 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✓

@Kleidukos Kleidukos mentioned this pull request Jun 17, 2023
Closed
2 tasks
@Mikolaj
Copy link
Member

Mikolaj commented Jun 17, 2023

CI froze. Let me restart.

mergify bot added a commit that referenced this pull request Jun 17, 2023
@mergify
Merge of #9032
4b496e4
@mergify mergify bot mentioned this pull request Jun 17, 2023
Closed
38 tasks
@mergify mergify bot merged commit 7de6ac2 into 3.10 Jun 18, 2023
@mergify mergify bot deleted the mergify/bp/3.10/pr-8755 branch June 18, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees

No one assigned

Labels

backport merge me Tell Mergify Bot to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mikolaj @ffaf1 @Kleidukos @BasLaa