Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put back docs for code-generators (fix #8887) #8969

Merged
merged 1 commit into from
May 26, 2023

Conversation

ulysses4ever
Copy link
Collaborator

Just fixing some docs, so nothing below applies I think.


Please include the following checklist in your PR:

Bonus points for added automated tests!

An optional list of preprocessors which can generate new modules
for use in the test-suite.

A list of executabes (possibly brought into scope by :pkg-field:`build-tool-depends`) that are run after all other
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ultimate nitpicking, there is a ␣␣ after “by”.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed! And thank you for reviewing!

Copy link
Collaborator

@ffaf1 ffaf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@ulysses4ever ulysses4ever force-pushed the t8887-code-generators-docs branch from 9c3305b to 8f4fd00 Compare May 24, 2023 15:22
@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels May 24, 2023
@ulysses4ever
Copy link
Collaborator Author

I assume it won't hurt to have it in 3.10.2?..

@ulysses4ever
Copy link
Collaborator Author

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented May 24, 2023

backport 3.10

✅ Backports have been created

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label May 26, 2023
@ulysses4ever ulysses4ever force-pushed the t8887-code-generators-docs branch from 8f4fd00 to 0d68e98 Compare May 26, 2023 15:32
@mergify mergify bot merged commit ccc09de into master May 26, 2023
@mergify mergify bot deleted the t8887-code-generators-docs branch May 26, 2023 17:38
mergify bot added a commit that referenced this pull request May 27, 2023
Put back docs for code-generators (fix #8887) (backport #8969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-generators documentation missing
3 participants