-
Notifications
You must be signed in to change notification settings - Fork 723
Ensure js-sources are used only with JavaScript arch #8748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
1d55f0e to
7ee5208
Compare
|
@hsyl20 I think now I got the test right. But I see no Javascript-capable compiler in the CI to check if they work. |
Unfortunately not in the foreseeable future. We are currently unable to add newest 9.4 revisions due to some GHA quirks and getting to 9.6 soon enough after release will already be a big feat, if we make it. Speaking about CI, please kindly rebase in 2h, after #8749 gets merged and then the CI breakage should be gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't cross-checked with the original PR, but the things I see LGTM.
|
Let me rebase myself. |
|
@mergify rebase |
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
✅ Branch has been successfully rebased |
7ee5208 to
e434f4e
Compare
|
To get the future behavior now, you can configure Or you can create a dedicated github account for squash and rebase operations, and use it in different |
e434f4e to
4d33ba6
Compare
|
Will branch 3.10 be rebased on master or does it require a backport? Master branch is currently only a few commits ahead. |
|
I think we will backport manually --- it's usually easy thanks to mergify and leaves a paper trail of the history of our decisions. Let me start with the CI fixes though, now that CI finally stabilized (famous last words). |
|
@mergify backport 3.10 |
✅ Backports have been created
|
Ensure js-sources are used only with JavaScript arch (backport #8748)
Fixes #8741