Add PackageInfos_ (#3909)

[blackheaven]

It's a first attempt, I'm open to feedback.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

[Mikolaj]

Thanks a lot! So, does this intend to fix #3909 completely or partially? Would you be able to come up with a simple test for the functionality? (It's the easiest to copy-paste and tweak an existing PackageTest or even add a clause to one if it already tests something close enough.) A tiny changelog file would be appreciated as well.

[blackheaven]

I'm lost, which changelog should I append my contribution to?

[ulysses4ever]

@blackheaven there's a checklist in the PR template, it has a reference for the changelog process

[blackheaven]

Finally

[blackheaven]

Is there anything I can do to help the merge?

[chreekat]

Hi, the impl looks fine and I'm glad this would solve a closure bloat problem in Nixpkgs!

My feedback mostly has to do with English and words in general:

• Info, i.e. information, is an uncountable noun like "water", so PackageInfo_ sounds better. "Informations" isn't considered a word, except (TIL) in legal settings. https://en.wiktionary.org/wiki/informations
• There are a few typos
• I had to go all the way to GitHub and read issue Add a Version_ module which does not depend on install dirs #3909 to understand what this patch is trying to accomplish. :D If I were you, I would create a whole new section in the manual explaining the new file. You could take the existing subsection "Accessing the package version" and promote it to a higher-level section. You could add some explanation of what you can find in that module, other than just version, and even why it was created in the first place.

[blackheaven]

Thanks for your feedback, I did my best to take them in account, however, if you can highlight my typos, I'd be grateful.

[chreekat]

Nice!

[chreekat]

Suggested change

	++ "module PackageInfo_* must include it also on the 'autogen-modules' field "
	++ "besides 'exposed-modules' and 'other-modules'. This specifies that "
	++ "module PackageInfo_* must include it in 'autogen-modules' as well as"
	++ " 'exposed-modules' and 'other-modules'. This specifies that "

[blackheaven]

I fixed it, but it's a copy-and-paste from Paths_*

[chreekat]

haha :) The original is what I would consider "European English": used widely among non-native speakers, understandable, but different from what a native speaker would say. I almost considered just leaving it, because I think it's better to say it's dialectical rather than "wrong". Fine either way

[blackheaven]

Let me know if I can do something to improve this PR, or if I can squash it

[Mikolaj]

LGTM

[Mikolaj]

@blackheaven: thank you very much. Re squashing the fixup commits, if you set the squash+merge_me label, Mergify is going to squash the PR when merging it (in two days).

[blackheaven]

Thanks, I did it manually.

[Mikolaj]

Perfect. Then go ahead and set the ordinary merge_me label.

[mergify]

⚠️ This pull request got rebased on behalf of a random user of the organization.
This behavior will change on the 1st February 2022, Mergify will pick the author of the pull request instead.

To get the future behavior now, you can configure bot_account options (e.g.: bot_account: { author } or update_bot_account: { author }.

Or you can create a dedicated github account for squash and rebase operations, and use it in different bot_account options.

[andreabedini]

For future reference this feature should have been conditional on cabal-version. See #9331