Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set -Wno-prepositive-qualified-module in Paths_*.hs #7352

Merged

Conversation

matthewbauer
Copy link
Collaborator

This is based on / similar to #7219

We used import qualified M in Paths_*.hs, which might be disallowed in
GHC 8.10 when -Wprepositive-qualified-module is set.


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

This is based on / similar to haskell#7219

We used import qualified M in Paths_*.hs, which might be disallowed in
GHC 8.10 when -Wprepositive-qualified-module is set.
@phadej
Copy link
Collaborator

phadej commented Apr 8, 2021

Maybe it would be easier to use https://downloads.haskell.org/ghc/latest/docs/html/users_guide/using-warnings.html?highlight=w#ghc-flag--w

{-# OPTIONS_GHC -w #-}

@Mikolaj
Copy link
Member

Mikolaj commented Apr 13, 2021

I guess it would be easier and more future proof, though a bit less safe. @matthewbauer, what do you think?

@matthewbauer
Copy link
Collaborator Author

Yeah, that's fine with me - I've updated with this change. I suppose there could be warnings in Paths_*.hs that we do want to know about, but then again it's pretty small and I don't think it will hurt to ignore those warnings.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 14, 2021

I didn't quite pass the checks. Warnings turned into errors, probably.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 23, 2021

@matthewbauer: ping! :)

@matthewbauer
Copy link
Collaborator Author

ok! updated with what I think fixes the issue...

@Mikolaj
Copy link
Member

Mikolaj commented Apr 27, 2021

@matthewbauer: thank you, the checks passed. @phadej: does it look good to you?

@Mikolaj Mikolaj self-requested a review May 4, 2021 13:55
@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2021

No objections from @phadej, but he is busy, so I've added myself to reviewers instead. LGMT. Merging.

@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2021

@emilypi: what's our etiquette, do I hit 'merge' now or ask the esteemed contributor to do so or seek yet another approval?

@emilypi
Copy link
Member

emilypi commented May 4, 2021

@Mikolaj we generally want 2 approvals before merging. I'll have a review in today.

@emilypi emilypi merged commit 4f8aeb2 into haskell:master May 4, 2021
@Mikolaj
Copy link
Member

Mikolaj commented May 4, 2021

Thank you @matthewbauer, @phadej and @emilypi!

@jkachmar
Copy link

jkachmar commented Aug 20, 2021

Are there plans to backport this to 3.4 or 3.6?

@emilypi
Copy link
Member

emilypi commented Aug 20, 2021

@mergify backport 3.6

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2021

Command backport 3.6: success

Backports have been created

Hey, I reacted but my real name is @Mergifyio

@emilypi
Copy link
Member

emilypi commented Aug 20, 2021

@mergify backport 3.4

@emilypi
Copy link
Member

emilypi commented Aug 20, 2021

@jkachmar good call. Backporting.

@mergify
Copy link
Contributor

mergify bot commented Aug 20, 2021

Command backport 3.4: success

Backports have been created

Hey, I reacted but my real name is @Mergifyio

@jkachmar
Copy link

Thanks so much!

emilypi added a commit that referenced this pull request Aug 20, 2021
Set -Wno-prepositive-qualified-module in Paths_*.hs (backport #7352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants