-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set -Wno-prepositive-qualified-module in Paths_*.hs #7352
Set -Wno-prepositive-qualified-module in Paths_*.hs #7352
Conversation
This is based on / similar to haskell#7219 We used import qualified M in Paths_*.hs, which might be disallowed in GHC 8.10 when -Wprepositive-qualified-module is set.
Maybe it would be easier to use https://downloads.haskell.org/ghc/latest/docs/html/users_guide/using-warnings.html?highlight=w#ghc-flag--w {-# OPTIONS_GHC -w #-} |
I guess it would be easier and more future proof, though a bit less safe. @matthewbauer, what do you think? |
Yeah, that's fine with me - I've updated with this change. I suppose there could be warnings in Paths_*.hs that we do want to know about, but then again it's pretty small and I don't think it will hurt to ignore those warnings. |
I didn't quite pass the checks. Warnings turned into errors, probably. |
@matthewbauer: ping! :) |
ok! updated with what I think fixes the issue... |
@matthewbauer: thank you, the checks passed. @phadej: does it look good to you? |
No objections from @phadej, but he is busy, so I've added myself to reviewers instead. LGMT. Merging. |
@emilypi: what's our etiquette, do I hit 'merge' now or ask the esteemed contributor to do so or seek yet another approval? |
@Mikolaj we generally want 2 approvals before merging. I'll have a review in today. |
Thank you @matthewbauer, @phadej and @emilypi! |
Are there plans to backport this to 3.4 or 3.6? |
@mergify backport 3.6 |
Command
Hey, I reacted but my real name is @Mergifyio |
@mergify backport 3.4 |
@jkachmar good call. Backporting. |
Command
Hey, I reacted but my real name is @Mergifyio |
Thanks so much! |
Set -Wno-prepositive-qualified-module in Paths_*.hs (backport #7352)
This is based on / similar to #7219
We used import qualified M in Paths_*.hs, which might be disallowed in
GHC 8.10 when -Wprepositive-qualified-module is set.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!