Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #5971. Free text fields preserve indentation #5981

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Apr 2, 2019

Starting with cabal-version: 3.0 free text fields
preserve indentation and blank lines.
In other words, we don't need single dots to indicate blank line.

IPI is not versioned. So we default to latest variant always.
This is little harm, as old GHC use old Cabal to print
IPIs. And free text fields are only informative.

Fixes #5938


category:            Data, Testing
description:
  A line before

  * foo

      * bar

      * quux

  @
  foo = bar
    where
      bar = foo

  quux = 42
  @

generates
Screenshot from 2019-04-02 14-52-54


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@phadej phadej requested a review from hvr April 2, 2019 10:31
@hvr hvr added this to the 3.0 milestone Apr 4, 2019
Copy link
Member

@hvr hvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Starting with `cabal-version: 3.0` free text fields
preserve indentation and blank lines.
In other words, we don't need single dots to indicate blank line.

IPI is not versioned. So we default to latest variant always.
This is little harm, as old GHC use old Cabal to print
IPIs. And free text fields are only informative.

Fixes #5938
description: staircase
               to
                 heaven
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants