Skip to content

Conversation

@quasicomputational
Copy link
Contributor

For efficiency reasons, matchDirFileGlob isn't a simple call to
getDirectoryContentsRecursive and then a filter with
fileGlobMatches. So test both that naive approach and the actual
approach to make sure they are both correct.

I only realised this was a problem right after #5284 was merged!

Since this is tests-only, I'll merge once Travis and AppVeyor are green.

Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

For efficiency reasons, matchDirFileGlob isn't a simple call to
getDirectoryContentsRecursive and then a filter with
fileGlobMatches. So test both that naive approach and the actual
approach to make sure they are both correct.
@quasicomputational quasicomputational merged commit 3bed6ee into haskell:master May 9, 2018
@23Skidoo
Copy link
Member

23Skidoo commented May 9, 2018

Looks good, thanks!

@andreasabel andreasabel added the re: globbing Concerning issues with globbing file patterns label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

re: globbing Concerning issues with globbing file patterns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants