-
Notifications
You must be signed in to change notification settings - Fork 725
Bump actions/checkout from 4 to 5 #11154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
#11151 although if this one passes CI by tomorrow morning I may defer to it; too late for me to debug what's up with the release workflow only on one arch. |
|
wtf, github actions seems to be glitching a lot the past few days |
|
Just have to wait on this one, it's reproducible and has nothing whatsoever to do with our code, it's GHA's framework for running Node actions |
|
actions/checkout#2246 |
eab37b3 to
4f37f33
Compare
``` /usr/bin/docker exec b6b00889ce59b62d3fdddcf068b7ca6cd09606da324e33b7e3754c74054cb218 sh -c "cat /etc/*release | grep ^ID" Error relocating /__e/node24_alpine/bin/node: pthread_getname_np: symbol not found ``` Upgrading both validate (was 3.19) and release (3.12) to 3.20 instead. I hope the release one was just a missed upgrade.
4f37f33 to
29241a2
Compare
|
As per latest version of second commit, Alpine older than 3.20 has been dropped. (Validate was using 3.19, which is why it wasn't also hitting the symbol resolution bug.) This also means the commit clock has restarted as of that push. |
| { image: "alpine:3.12" | ||
| , installCmd: "apk update && apk add" | ||
| , toolRequirements: "${{ needs.tool-output.outputs.apk_tools }}" | ||
| , DISTRO: "Unknown" | ||
| , ARTIFACT: "x86_64-linux-alpine312" | ||
| , ADD_CABAL_ARGS: "--enable-split-sections" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke the ghcup metadata script:
cabal/scripts/release/create-release-metadata-for-ghcup.sh
Lines 34 to 39 in 6ba466c
| Linux_Alpine: | |
| '( >= 3.12 && < 3.20)': &cabal-${YV}-alpine312-64 | |
| $(print_uri_hash "cabal-install-$VERSION-x86_64-linux-alpine312.tar.xz") | |
| '>= 3.20': | |
| $(print_uri_hash "cabal-install-$VERSION-x86_64-linux-alpine320.tar.xz") | |
| unknown_versioning: *cabal-${YV}-alpine312-64 |
It's a good idea to CC code authors on PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea to CC code authors on PRs.
Apologies. I see I'm in the reviewers list, but it went through my radar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea to CC code authors on PRs.
Apologies. I see I'm in the reviewers list, but it went through my radar.
Or is that because I just commented here? shrug
Bumps actions/checkout from 4 to 5.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
08c6903Prepare v5.0.0 release (#2238)9f26565Update actions checkout to use node 24 (#2226)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)