Fix file+noindex URI usage on Windows

[jasagredo]

Concluded on using file+noindex:C:/some/path on Windows as discussed on Matrix.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[ulysses4ever]

Terrific! Any chance for a test?

[jasagredo]

I can't push because Git operations on github are down at the moment. Will push tomorrow.

As for the tests @ulysses4ever, the current test-suite makes use of this both by the roundtrip of project configurations and by some tests that make use of local+noindex repos such as the ones added recently by @9999years. I consider that sufficient testing.

[9999years]

Windows paths are so tricky

[ulysses4ever]

the current test-suite makes use of this both by the roundtrip of project configurations and by some tests that make use of local+noindex repos such as the ones added recently by @9999years. I consider that sufficient testing.

It's just that if anything in the current setup exercises this functionality, I expect the setup to need an update after these changes.

[jasagredo]

The previous PR that was merged did change the OutputNormalizer. It then worked with //./ paths. Now it works with file+noindex:C:/ paths.

[jasagredo]

One could argue that the right syntax would be:

file+noindex:///C:/foo

But that is not understood by network-uri. It is however what .NET does:

➜ [System.Uri]'C:/foo.txt'

AbsolutePath   : C:/foo.txt
AbsoluteUri    : file:///C:/foo.txt
...

In any case .NET also supports the syntax we use here so it should be fine:

➜ [System.Uri]'file:C:/foo.txt'

AbsolutePath   : C:/foo.txt
AbsoluteUri    : file:///C:/foo.txt
...

Probably the right thing to do would be to make use of file-uri for file+noindex paths, but that would require us to not first read it as a network-uri. The good news is that file-uri understands both versions and both are "the same" so once we make this change and recommend file:/// the previous code won't break:

ghci> parseFileURI ExtendedWindows  "file:///C:/foo.txt"
Right (FileURI {fileAuth = Nothing, filePath = "C:/foo.txt"})
ghci> parseFileURI ExtendedWindows  "file:C:/foo.txt"
Right (FileURI {fileAuth = Nothing, filePath = "C:/foo.txt"})

cc @hasufell

[Mikolaj]

@mergify backport 3.14

[mergify]

backport 3.14

✅ Backports have been created

Details

• #10876 Backport #10746: Fix file+noindex URI usage on Windows has been created for branch 3.14 but encountered conflicts

[ulysses4ever]

The title of this PR doesn't match the commit title which makes it very confusing because there was another PR with a title like this one (#10728).

Sorry for a silly question, but is "local+noindex" the same as "file+noindex"?

[jasagredo]

It should always have been file+noindex. There is no local+noindex except on a single comment. Therefore the title of the commit is wrong.