Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate path separator duplicates #10646

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Dec 17, 2024

Fixes #10645, a small Windows gotcha missed with #10546.


@philderbeast philderbeast changed the title Configuration from message path separator duplicates Deduplicate path separator duplicates Dec 17, 2024
@philderbeast philderbeast force-pushed the fix/path-sep-duplicates branch from 2d03f00 to 53fd7b0 Compare December 17, 2024 17:02
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused: is the .md file a GitHub artifact, or did you really add two changelog.d entries?

@philderbeast philderbeast force-pushed the fix/path-sep-duplicates branch from 53fd7b0 to ca61a07 Compare December 17, 2024 17:13
@philderbeast
Copy link
Collaborator Author

I'm confused: is the .md file a GitHub artifact, or did you really add two changelog.d entries?

Thanks for catching that mistake of mine @geekosaur. I let the .md slip in. I rename locally to check the markdown preview. I've deleted that extra file now.

Can we use a .md extension for changelog.d entries?

@geekosaur
Copy link
Collaborator

geekosaur commented Dec 17, 2024

changelog-d doesn't care; the only special name is config, where its own configuration is stored, and you can't use subdirectories. It might even be better to use the extension, since that way GitHub will also render it (although it will probably be confused by the YAML frontmatter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using configuration from show duplicate paths
2 participants