Delete second checkPackageDescription call

[parsonsmatt]

While diagnosing slow check times, I identified that file glob expansion was very slow, even on literal paths (#10495). This was made worse because Cabal would expand a glob four times for each extra-source-files line.

Fortunately, we can halve this easily: we call checkPackageDescription twice in checkGenericPackageDescription. This PR simply removes one of the calls in the function.

On our codebase, this patch has the effect of reducing the time spent expanding globs from 34s to 17s, bringing the time to do cabal repl --repl-options "-e ()" from 50s to 33s.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[parsonsmatt]

For reference, the other call is on line 238: https://github.com/parsonsmatt/cabal/blob/7c9e0de9a1200f8663bd1ea87d5d82a770b4eee7/Cabal/src/Distribution/PackageDescription/Check.hs?plain=1#L238

[ffaf1]

Very good find.

[ffaf1]

I don't think this requires a Template A, as it fixes a bug.

[ulysses4ever]

Thanks!

Excuse us if we're slow in other PRs of yours: it's a release time for us. But we'll get there.

[parsonsmatt]

Y'all are reviewing these quickly, no worries at all! 😄 We will most likely be using a patched version while we wait for relesae, so there's no rush on our end.