Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoformat more directories #10491

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Autoformat more directories #10491

wants to merge 1 commit into from

Conversation

9999years
Copy link
Collaborator

WIP, pretty scuff; needs a lot of attention to make Fourmolu work nicely with various CPP blocks

@ulysses4ever
Copy link
Collaborator

bold! People seem to want to scrap auto-formatting as it creates a noticeable tension with new/rare contributors.

One thing to consider is the release cycle. We're about to release cabal-install-3.14.1.0, and there will be many backports, which reformatting may complicate. A better point for it may be a little while after a release.

@geekosaur
Copy link
Collaborator

That's likely to feel like 3.10 after the initial fourmolu pass, though.

@9999years
Copy link
Collaborator Author

auto-formatting [...] creates a noticeable tension with new/rare contributors

FWIW I was very surprised to hear this -- I find an autoformatter that clearly fails in CI so much easier to work with as an infrequent contributor than a (usually vague) style guide that's variably enforced by individual reviewers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants