Deduplicate path separator duplicates #10646
Open
+663
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philderbeast
changed the title
philderbeast
force-pushed
the
fix/path-sep-duplicates
branch
from
2d03f00 to
53fd7b0
Compare
geekosaur
approved these changes
Dec 17, 2024
philderbeast
force-pushed
the
fix/path-sep-duplicates
branch
from
53fd7b0 to
ca61a07
Compare
Thanks for catching that mistake of mine @geekosaur. I let the Can we use a |
|
|
|
Reverting to draft while I settle some Windows versus POSIX file path issues. |
philderbeast
force-pushed
the
fix/path-sep-duplicates
branch
18 times, most recently
from
9134cfa to
bfda13a
Compare
- Manually replace path separators before anything else
- Add a section on cabal-testsuite changes - Rename the function to readFileVerbatim
philderbeast
force-pushed
the
fix/path-sep-duplicates
branch
from
bfda13a to
14850de
Compare
geekosaur
approved these changes
Dec 24, 2024
Co-authored-by: brandon s allbery kf8nh <[email protected]>
Co-authored-by: brandon s allbery kf8nh <[email protected]>
Co-authored-by: brandon s allbery kf8nh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10645, a small Windows gotcha missed with #10546.
I really had to get into the weeds with this one. The
assertOutputContainsfunction was modifying the output (a test actual value) before comparision with the unmodified actual value. This change was not visible. I've added anassertOnfunction (thatassertOutputContainscalls) that takes aNeedleHaystackconfiguration for how the search, expectation and display are made. I had wanted to add a pilcrow¶for line endings but the terminal output is restricted to ASCII so I've marked line beginnings with^and line endings with$. The needle (the expected output fragment) is shown annotated this way as can the haystack (the output). The haystack is not shown annotated with line delimiters but can be.The
concatOutputfunction, I've renamed tolineBreaksToSpaces. There's more detail on thecabal-testsuitechanges in the changelog entry. One benefit of using an.mdextension forchangelog.d/pr-10646.mdis that typos are caught by CI.significance: significantin the changelog file.