Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-validate: Steps change depending on options which choose steps #10565

Open
9999years opened this issue Nov 20, 2024 · 0 comments
Open

cabal-validate: Steps change depending on options which choose steps #10565

9999years opened this issue Nov 20, 2024 · 0 comments
Labels
cabal-validate validate.sh (cabal-validate) test suite runner meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites

Comments

@9999years
Copy link
Collaborator

The build step will build... the stuff used by the other steps you're running!

E.g. solver-benchmarks is only built if --solver-benchmarks is passed... but if you use --step solver-benchmarks-run manually, it won't be built. cabal-install-solver will not be built if --lib-only is passed.

So this introduces two confusing behaviors:

  1. ./validate.sh -s build && ./validate.sh -s solver-benchmarks will error because solver-benchmarks aren't built.
  2. ./validate.sh -s build won't catch compile errors in solver-benchmarks, which is a little confusing. ./validate.sh -s build should... build everything that gets tested in CI, I think!

Related:

Proposal: There should be a build group which builds everything, and steps build-lib, build-cli, and build-solver-benchmarks which build specific sets of libraries.

@9999years 9999years added meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites cabal-validate validate.sh (cabal-validate) test suite runner labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal-validate validate.sh (cabal-validate) test suite runner meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites
Projects
None yet
Development

No branches or pull requests

1 participant