Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-validate: Too many ways to choose steps #10564

Open
9999years opened this issue Nov 20, 2024 · 0 comments
Open

cabal-validate: Too many ways to choose steps #10564

9999years opened this issue Nov 20, 2024 · 0 comments
Labels
cabal-validate validate.sh (cabal-validate) test suite runner meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites

Comments

@9999years
Copy link
Collaborator

The CLI defaults are unclear, there's about three different ways to choose which steps are run, and it's not obvious how they interact. (Even to me, and I wrote it!)

For example:

  • --cli tests cabal-install in addition to Cabal, but there's no --cli-only flag.
  • --run-lib-tests and similar options exist only to add or remove specific --steps. (But will be ignored if any --steps are given.)
  • --step adds a specific step to be run (can be used multiple times).

Proposal: Remove the --cli, --lib-only, and all other flags that exist to enable/disable a specific step. (Needs groups of steps.)

  • Instead of --cli, you'll use --group Cabal --group cabal-install (this makes it explicit that --cli also tests the Cabal library).
  • Instead of --run-lib-suite you'll use --step lib-suite.
  • Instead of --no-run-lib-suite you'll specify the steps you want to run, e.g. --step lib-tests --step cli-tests --step cli-suite (that's the default behavior with --no-run-lib-suite, but probably not what you want!)
@9999years 9999years added meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites cabal-validate validate.sh (cabal-validate) test suite runner labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal-validate validate.sh (cabal-validate) test suite runner meta: tracking re: devx Improving the cabal developer experience (internal issue) type: testing Issues about project test suites
Projects
None yet
Development

No branches or pull requests

1 participant