Merged
Conversation
The windows jobs were subtly broken by haskell#613, which caused the build products to live in bytestring-*/dist-newstyle instead of dist-newstyle. This didn't appear to break immediately because we restored cached stuff in dist-newstyle including stale executables. It wasn't until a week of inactivity caused our cache to expire that the breakage became appropriately obvious. I don't really understand what went wrong with the centos job; I just borrowed the workaround from haskell/text#541.
Bodigrim
approved these changes
Nov 16, 2023
clyring
added a commit
that referenced
this pull request
Jan 30, 2024
The windows jobs were subtly broken by #613, which caused the build products to live in bytestring-*/dist-newstyle instead of dist-newstyle. This didn't appear to break immediately because we restored cached stuff in dist-newstyle including stale executables. It wasn't until a week of inactivity caused our cache to expire that the breakage became appropriately obvious. I don't really understand what went wrong with the centos job; I just borrowed the workaround from haskell/text#541. (cherry picked from commit bf5f5da)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows jobs were subtly broken by #613, which caused the build products to live in bytestring-*/dist-newstyle instead of dist-newstyle. This didn't appear to break immediately because we restored cached stuff in dist-newstyle including stale executables. It wasn't until a week of inactivity caused our cache to expire that the breakage became appropriately obvious.
I don't really understand what went wrong with the centos job; I just borrowed the workaround from haskell/text#541.