Avoid error inside a pure value, and use instead the IO Monad's fail#116
Closed
berdario wants to merge 1 commit intohaskell-tls:masterfrom
Closed
Avoid error inside a pure value, and use instead the IO Monad's fail#116berdario wants to merge 1 commit intohaskell-tls:masterfrom
berdario wants to merge 1 commit intohaskell-tls:masterfrom
Conversation
|
This is not the only place: https://github.com/vincenthz/hs-certificate/blob/7041244d0dd3946d96af66611b2760d2478e055f/x509-system/System/X509/MacOS.hs#L23 I'm seriously concerned to see such novice issues in a security critical library. |
Collaborator
|
Thanks @berdario, however I went with the other PR #125 prefering the use of @hasufell and I'm seriously concerned how many dicks such as yourself, are littering the haskell community, ready for judgmental comments and insults like the one above. maybe you should ask for your money back. oh wait. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, to catch this runtime error, you'd be forced to use something like Control.Exception.evaluate