refactors & hlint rules #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-Latukha
force-pushed
the
2021-10-20-refactors
branch
from
5ee49b1 to
5450906
Compare
Anton-Latukha
force-pushed
the
2021-10-20-refactors
branch
from
5450906 to
ab67941
Compare
Anton-Latukha
force-pushed
the
2021-10-20-refactors
branch
from
e6f20a6 to
369cce7
Compare
As they are the same code, extending some Variadic set with Closed one.
Here the local `compose` fun gets flipped, but the adjustments of arguments actually already sliiped into previous commits, a downside of not making commits in time.
Anton-Latukha
force-pushed
the
2021-10-20-refactors
branch
from
e6fd4e3 to
2173d12
Compare
M benchmarks/Main.hs M main/Main.hs M main/Repl.hs M src/Nix/Builtins.hs M src/Nix/Cited/Basic.hs M src/Nix/Effects/Derivation.hs M src/Nix/Expr/Shorthands.hs M src/Nix/Expr/Strings.hs M src/Nix/Parser.hs M src/Nix/Pretty.hs M src/Nix/Reduce.hs M src/Nix/Render.hs M src/Nix/String.hs M tests/EvalTests.hs M tests/Main.hs M tests/NixLanguageTests.hs M tests/ParserTests.hs M tests/PrettyParseTests.hs
Anton-Latukha
force-pushed
the
2021-10-20-refactors
branch
from
f31a6e1 to
735b22e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I know & in most cases
foldis just as efficient as{,m}concat&foldMapasconcatMap. I guard their effectiveness with supplying type signatures.foldenablesHLintto provide further code refactoring instruction & to find function replacements by type signatures.& further refactors, work actually started from
Inferencecode refactors & tantrum spread, so currently trying to carve diff into small commits.