Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: update #983

Merged
merged 56 commits into from
Aug 13, 2021
Merged

Parser: update #983

merged 56 commits into from
Aug 13, 2021

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Aug 12, 2021 •
edited
Loading

  • Parser:
    • (nixExpr -> nixExprAlgebra).
    • (nixTopLevelForm -> nixExpr).
    • rm symbol from export - they are too core - solving them away inside Parser is crucial, while also too simple symbol x = char x <* whiteSpace that people can look-it up/infer themselves, whiteSpace so far is requires to be exported, until the situation with Windows \r\n gets clearer (when the situation would be properly solved - that export would be superfluous).
    • use of takeWhile{,1}P, which strongly optimizes (magnitudes) the according actions in the parser.
    • module organization.
    • all other refactors.

@Anton-Latukha
default.nix: upd rev
060fb02
@Anton-Latukha
Parser: operator: m upd
e7ff8dc
@Anton-Latukha
Parser: , upd
423aae4
@Anton-Latukha
Parser: rename (<+>) -> (<|>)
0f986dc
@Anton-Latukha
Parser: add annotateLocationNamed1; (<?> -> label)
63bfbc3
@Anton-Latukha
Parser: annotate(LocationNamed1 -> NamedLocation)
a4065ab
@Anton-Latukha
Parser: swap annotateLocation{,1} names
f9bc17f 
1 was misleading as it returned normal annotation.

Now 1 is used for a minimal AnnUnit.
@Anton-Latukha
Parser: m upd: use Parser type synonym
1d90764
@Anton-Latukha
Parser: m org
05bc113
@Anton-Latukha
Parser: m layout: aligning (<|>)
9a3582d
@Anton-Latukha
Expr: Types: Recursivity: add instances {Semigroup, Monoid}
a7a3b0a
@Anton-Latukha
Parser: m refactor: megaparsec (string->chunk)
a568d72
@Anton-Latukha
Parser: reorganization
3fa70e7 
Now order in the module is mode logical & catalogued.

It has pretty much the same order of following as the datatype of NExpr it
parses into.
@Anton-Latukha
dep: megaparsec 9.1
80a3b4f
@Anton-Latukha
tests: ParserTests: m refactor
4424049
@Anton-Latukha
tests: ParserTests: m refactor
53d4107
@Anton-Latukha
tests: ParserTests: assertParsePrint: upd output form factor
e6b2011
@Anton-Latukha
tests: ParserTests: asserParseFail: improve output
2ece6b0
@Anton-Latukha
tests: ParserTests: throwParseError: improve output
4bb170f
@Anton-Latukha
Expr.Strings: remote(PlainEmpty->EmptyPlains)
3bbb712
@Anton-Latukha
Parser: anti(Start -> quoteWithEnd)
dd131b0
@Anton-Latukha
Parser: identifier: m refactor
2ee8035
@Anton-Latukha
Parser: add binary; refactor
5e8d561
@Anton-Latukha
Parser: NOperatorDef: org constructors
0d247d7
@Anton-Latukha
Parser: NOperatorDef: org constructors
28d491b
@Anton-Latukha
Parser: opWithLoc: org args
ea35c7e
@Anton-Latukha
Parser: prefix: org args
1e26aa9
@Anton-Latukha
Expr.Types.Annotated: m upd
0214fac
@Anton-Latukha
Parser: skipLineComment': add doc note
9741734
@Anton-Latukha
Parser: lexeme: add doc
e055a09
@Anton-Latukha
Parser: nixExpr: add doc
9932995
@Anton-Latukha
Parser: add fullExprParser
f6467cb
@Anton-Latukha
Parser: add parseNixFile'
f83a551
@Anton-Latukha
Parser: add parseNixText'
1ab5833
@Anton-Latukha
Parser: add detectPrecedence; rft get{Unary,Binary,Special}Operator
9b54719
@Anton-Latukha
Parser: OperatorInfo: add note to reduce it
b56e15e
@Anton-Latukha
Parser: add getExprAfterP
f1091c6 
Why: see the very next commits
@Anton-Latukha
Parser: add getExprAfterReservedWord & use it
2f8e568
@Anton-Latukha
Parser: rm semi (easier to read & further refactor)
ba5b5a4
@Anton-Latukha
Parser: rm comma
20bccb7
@Anton-Latukha
Parser: rm equals
52d6426
@Anton-Latukha
Parser: rm question
e13e623
@Anton-Latukha
Parser: add symbols & use
8bb95c4
@Anton-Latukha
Parser: add getExprAfterSymbol
208bf64
@Anton-Latukha
Parser: refactor antiquotation
b35a730
@Anton-Latukha
Parser: nixTop(l->L)evelForm (name properly)
4751965
@Anton-Latukha
Parser: nixExpr(->Algebra) (name was mesleading & colliding)
05686f9
@Anton-Latukha
Parser: (nixTopLevelForm -> nixExpr)
ed08e44
@Anton-Latukha
Parser: full(ExprParser->Content)
0f6cc56
@Anton-Latukha
Parser: (getE->e)xprAfter* (this is how other functions are named)
db99de8
@Anton-Latukha
Parser: m refactor
ad9bf40
@Anton-Latukha
Parser: rm symbol & symbols from export
ac71d02 
They are just `lexeme . char`
@Anton-Latukha
Parser: nixUri: refactor
02b33ff
@Anton-Latukha
Parser: ref: more Text, use takeWhile{,1}P
f9b93a1 
megaparsec texts promise takeWile{,1}P to give huge (magnitude) of speedup for according operation.
@Anton-Latukha
Parser: nixString': refactor
a05a7c4
@Anton-Latukha
{TH, Exec}: use patterns for Fix
63d6463
@Anton-Latukha Anton-Latukha marked this pull request as ready for review August 13, 2021 11:20
@Anton-Latukha Anton-Latukha merged commit 31c9e99 into master Aug 13, 2021
@Anton-Latukha Anton-Latukha deleted the 2021-08-12-upd branch August 13, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Anton-Latukha