add CLI key --version #703
Conversation
Anton-Latukha
force-pushed
the
2020-08-25-cli-add-version
branch
2 times, most recently
from
ad339df to
0207b1c
Compare
src/Nix/Options/Parser.hs
Outdated
| <$> (fromMaybe Informational <$> optional | ||
| (option | ||
| (do | ||
| a <- str | ||
| if all isDigit a | ||
| then pure $ decodeVerbosity (read a) | ||
| else fail "Argument to -v/--verbose must be a number" | ||
| ) | ||
| (short 'v' <> long "verbose" <> help "Verbose output") | ||
| (option |
There was a problem hiding this comment.
I think the loss of indentation makes the nesting less clear here, but, again, I don't care too much.
|
@Anton-Latukha It would be nice to include this in the next release. Do you want to make changes to this PR or can it be merged as-is? |
|
Oops, I had overlooked that you had marked the PR as a draft. I guess there's no need to wait for it then. |
|
There is no need to wait for it at all. It does not if PRs are green or a draft. Stable tImely releases are much more important than postponing the release to include current pipeline features into them (last one is the non-terminating algorithm). If some PRs need to get in - it is properly important to include fix PRs into the release. |
Anton-Latukha
force-pushed
the
2020-08-25-cli-add-version
branch
from
0207b1c to
2320eff
Compare
|
Seems like this PR is affected by #706 too. |
Anton-Latukha
force-pushed
the
2020-08-25-cli-add-version
branch
from
2320eff to
b64d84b
Compare
Anton-Latukha
force-pushed
the
2020-08-25-cli-add-version
branch
from
b64d84b to
45fd8e0
Compare
Anton-Latukha
force-pushed
the
2020-08-25-cli-add-version
branch
from
45fd8e0 to
8bb47fc
Compare
Closes #702
The key itself is done in the first commit.
About
--versionoption--versionoption seems to not belong inhelphead message (helper). It, simply, is not a helper-related information.Tried to include
--versioninnixOptionsbut NOR was successful, NOR--versionfits to be innixOptionsabstraction, which holds interpretation keys.So, since it does not belong to
{helper, nixOptions}-versionOptis separate abstraction.The proper way to get
versionnumber (in the current Haskell ecosystem) - is to take it from Cabal autogeneratedPaths_hnix, so it is loaded right from thehnix.cabal version:field, which is done here.The usage of Cabal provided metadata for this, makes direct
> ghcicommand not viable (nor it was in HNix, the project can not be loaded from GHCi for other reasons). Nor GHCi expected to work, since there iscabal v2-replfor loading packages.Proper
versionimplementation goes against my request of having Nix package that is not tied to Cabal #545, but that target is not on the horizon, and we should decide on the hardcode policy before that, as project development would face tradeoffs, and some minor hardcode would be an answer some times.So I decided that returning a
--versionfor people is beneficial, people now able to check and guard the version easily, and use the tool to automate things.The second commit is alignment clean-up.