Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Deprecate multiple app blocks in a waypoint.hcl #3466

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented Jun 16, 2022

No description provided.

return fmt.Sprintf("%d validation errors: %s", len(v), strings.Join(values, ", "))
}

const AppeningHappening = "More than one app stanza within a waypoint.hcl file is deprecated, and will be removed in 0.10.\nPlease see https://discuss.hashicorp.com/waypoint/xxyyzz for more information."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍🍳💋

Copy link
Contributor

@xiaolin-ninja xiaolin-ninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failing go test is from validate_test.go not being updated with the new output.

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, @evanphx - Before we merge, we should fix the unit tests. Looks like there are some legit failures with this change.

@briancain briancain added this to the 0.9.0 milestone Jun 22, 2022
Co-authored-by: Shirley Xiaolin Xu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants