Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Backport of builtin/k8s: Ensure pod.container.static_environment is applied into release/0.8.x #3209

Conversation

hc-github-team-waypoint
Copy link
Collaborator

Backport

This PR is auto-generated from #3197 to be assessed for backporting due to the inclusion of the label backport/0.8.x.

The below text is copied from the body of the original PR.


Why the change?

I noticed that the following configuration did not apply the env vars to the app container as expected.

deployment {
  use "kubernetes" {
    pod {
      container {
        static_environment = {
          "MY_COOL_ENV_VAR" = "MY_COOL_VALUE"
        }
      }
      # ...

How do I test this?

  1. git checkout k8s/container-static-env
  2. make bin
  3. Configure a deployment with pod.container.static_environment as above
  4. Deploy
  5. Verify the defined env vars were applied to the app container correctly
  6. Try hoisting the static_environment config:
    deployment {
      use "kubernetes" {
        static_environment = {
          # ...
  7. Deploy again
  8. Verify the env vars are still applied correctly

@hc-github-team-waypoint hc-github-team-waypoint merged commit 983c0f8 into release/0.8.x Apr 11, 2022
@hc-github-team-waypoint hc-github-team-waypoint deleted the backport/k8s/container-static-env/jointly-capital-bream branch April 11, 2022 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants