This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of e6b2d60 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
gregone
force-pushed
the
ui/artifact-overview-popover
branch
from
January 11, 2022 19:05
2caf4ee
to
b952a4f
Compare
gregone
force-pushed
the
ui/artifact-overview-popover
branch
from
January 11, 2022 19:23
b952a4f
to
23565e0
Compare
jgwhite
suggested changes
Jan 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Only minor change requests from me.
@jgwhite updated with fixed for all your comments |
jgwhite
approved these changes
Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Artifact popover (#2740) will be visible on the resources page. But that page didn't exist, so I started creating it.
The popover PR will come later.