This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Delete deployment (CLI changes, GCR support) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the command to only support one deployment. I think this may actually be desired – awk workflows from `deployment list` and xargs seems like the modern approach here.
pearkes
force-pushed
the
delete-deployment
branch
from
863e8f8 to
df14998
Compare
alexcarpenter
added a commit
that referenced
this pull request
Oct 13, 2021
* Init <GradientBox /> component * SVG alignment * Add TS interface
alexcarpenter
added a commit
that referenced
this pull request
Oct 13, 2021
* Init <GradientBox /> component * SVG alignment * Add TS interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the CLI to:
For cloudrun it now supports the
DestroyFunc, which deletes the underlying revision.It also adds a
GetDeploymentmethod to the server to support the individual deletionworkflow.
Finally, used a new version ofprotoc-gen-goso there are some major changes there isolated in a commit. Everything seems to work so far.