Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Track step groups more accurately #1480

Closed
wants to merge 6 commits into from
Closed

Track step groups more accurately #1480

wants to merge 6 commits into from

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented May 17, 2021

This goes along with hashicorp/waypoint-plugin-sdk#31 to properly track concurrent step groups to avoid confusing UI issues.

@evanphx evanphx requested a review from a team May 17, 2021 21:04
@github-actions github-actions bot added the core label May 17, 2021
@krantzinator
Copy link
Contributor

Is this supposed to fix the problem with step groups exiting too quickly to log their final state, or be part 1 in the puzzle?
I just ran a waypoint init (installed server in nomad, waypoint-examples/nomad/nodejs) off this branch and got an unfinished state:

$ waypoint init
✓ Configuration file appears valid
✓ Connection to Waypoint server was successful
✓ Project "example-nodejs" and all apps are registered with the server.
⠹ Validating required plugins...
$

@krantzinator
Copy link
Contributor

Ah maybe I should wait on this until the sdk PRs are merged in 😄

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the sdk fixes are in and I have the same issue with waypoint int

wpinit

And then the waypoint up output is completely lost 🤔

Screenshot from 2021-05-19 11-34-03

Or trying a second time:

wpup

@evanphx evanphx added this to the 0.4.x milestone Jun 23, 2021
@krantzinator
Copy link
Contributor

@evanphx Should we move this to 0.5 milestone?

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@xiaolin-ninja
Copy link
Contributor

@evanphx please magnificent sir amongst sirs, will we carry this wonderful PR to its completion at a date in the near future befitting of your sirness? <3

@evanphx
Copy link
Contributor Author

evanphx commented Sep 8, 2022

@xiaolin-ninja A chance to debug, perchance to find this bug most foul! Forthwith, I shall turn the hourglass once again and bring the powers that be upon it!

@briancain
Copy link
Member

Should we close this?

@evanphx evanphx closed this May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants