This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Convert Docker to use new SDK Resource Manager #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellh
added
the
pr/no-changelog
krantzinator
approved these changes
May 18, 2021
izaaklauer
approved these changes
May 18, 2021
briancain
suggested changes
May 18, 2021
Co-authored-by: Brian Cain <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the Docker plugin to use the new resource manager library in the SDK. This will improve error handling and makes the code a bit more structured. There is no other functionality changes in this PR.