Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

builtin/k8s: Ensure pod.container.static_environment is applied #3197

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented Apr 8, 2022

Why the change?

I noticed that the following configuration did not apply the env vars to the app container as expected.

deployment {
  use "kubernetes" {
    pod {
      container {
        static_environment = {
          "MY_COOL_ENV_VAR" = "MY_COOL_VALUE"
        }
      }
      # ...

How do I test this?

  1. git checkout k8s/container-static-env
  2. make bin
  3. Configure a deployment with pod.container.static_environment as above
  4. Deploy
  5. Verify the defined env vars were applied to the app container correctly
  6. Try hoisting the static_environment config:
    deployment {
      use "kubernetes" {
        static_environment = {
          # ...
  7. Deploy again
  8. Verify the env vars are still applied correctly

@jgwhite jgwhite requested a review from a team April 8, 2022 10:47
@jgwhite jgwhite self-assigned this Apr 8, 2022
@github-actions github-actions bot added the plugin label Apr 8, 2022
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants