Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Update links in ResourcesTableExtended component #3172

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

gregone
Copy link
Contributor

@gregone gregone commented Apr 4, 2022

Fixes #3156

Looks some data was not passed in #2777 and that carried over with the new routes. This PR removes the need for a @route argument in the ResourcesTableExtended component and instead infers it from the resource type for each link

Screen.Recording.2022-04-04.at.19.52.42.mov

@github-actions github-actions bot added the ui label Apr 4, 2022
@gregone gregone requested a review from a team April 4, 2022 17:53
@jgwhite
Copy link
Contributor

jgwhite commented Apr 4, 2022

Just tried this out locally and I’m hitting this error against mirage on /default/marketing-public/app/wp-matrix/resources:

CleanShot 2022-04-04 at 21 08 39@2x

Copy link
Contributor

@jgwhite jgwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@gregone gregone merged commit aad3884 into main Apr 7, 2022
@gregone gregone deleted the ui/3156-resource-table-links branch April 7, 2022 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: inert links in app resources table
2 participants