This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
core: HTTP Trigger URLs #2970
Merged
core: HTTP Trigger URLs #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
added
the
pr/no-changelog
briancain
removed
the
pr/no-changelog
briancain
commented
Feb 2, 2022
briancain
force-pushed
the
feat/core/http-trigger-urls
branch
from
73e02d9 to
fa64bf9
Compare
briancain
force-pushed
the
feat/core/http-trigger-urls
branch
from
fa64bf9 to
dc884f8
Compare
catsby
reviewed
Feb 2, 2022
briancain
force-pushed
the
feat/core/http-trigger-urls
branch
from
9bfd611 to
4d7af76
Compare
catsby
reviewed
Feb 3, 2022
This commit updates the run trigger http func to stream all job output that's running concurrently back to the requester.
Otherwise, we return an HTTP 204 No Content for initiated triggers with no auth.
This commit updates the crafted message format that is streamed back to the user. Now we return a value and valueType, where value is an interface that is the direct terminal event value, and the valueType is the type of terminal stream event. Update stream message example in trigger docs
This commit moves a few extra nested levels of code out for code readability. Functionally it operates the same.
Always respect a cancelled context, otherwise we could spin waiting for the next message and ignore a cancel request
briancain
force-pushed
the
feat/core/http-trigger-urls
branch
from
05ce41c to
daa3d92
Compare
|
Force pushed to fix a proto merge conflict off main |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new endpoint into Waypoint server for
running Trigger URLs. By request, a user can concurrently stream back
job event stream output through HTTP. It does not allow un-authenticated
triggers to stream back the job event stream, and returns an HTTP 204 No Content.
Fixes #2987