Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Update ALB Releaser to use Resource Manager #1648

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jun 11, 2021

Similar to #1528 and #1477, this PR updates the ALB Releaser to use the Waypoint SDK Release Manager for creation and deletion.

Also implements #1081 and fixes #1011

Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @catsby ! This looks legit, excited to see a more complicated use-case of the new resource manager feature.

Most of my comments are just UI output and error formatting comments. Overall the PR looks great to me 😄

.changelog/1611.txt Outdated Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Show resolved Hide resolved
builtin/aws/alb/releaser.go Outdated Show resolved Hide resolved
builtin/aws/alb/releaser.go Outdated Show resolved Hide resolved
@briancain briancain linked an issue Jun 14, 2021 that may be closed by this pull request
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the updates! ✨

@catsby catsby force-pushed the f-alb-resource-manager branch from c5135de to 260d6ec Compare June 16, 2021 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants