Merge pull request #4746 from hashicorp/backport/bug/pipelines/dont-a…

…ppend-same-context/curiously-dear-mollusk

This pull request was automerged via backport-assistant

.changelog/4744.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+config: Remove extra eval context append for parsing configs which caused a slowdown during pipeline config parsing.
+```

internal/config/pipeline.go

@@ -83,8 +83,6 @@ func (c *Config) Pipelines() []string {
 // Note that currently this parsing function does not attempt to detect cycles
 // between embedded pipelines.
 func (c *Config) Pipeline(id string, ctx *hcl.EvalContext) (*Pipeline, error) {
-	ctx = appendContext(c.ctx, ctx)
-
 	// Find the pipeline by progressively decoding
 	var rawPipeline *hclPipeline
 	for _, p := range c.hclConfig.Pipelines {

internal/config/pipeline_test.go

@@ -305,6 +305,20 @@ func TestPipelineProtos(t *testing.T) {
 			},
 		},
 
+		{
+			"pipelines_many_many_many.hcl",
+			func(t *testing.T, c *Config) {
+				require := require.New(t)
+
+				pipelines, err := c.PipelineProtos()
+				require.NoError(err)
+				require.Len(pipelines, 7)
+
+				require.Equal(pipelines[0].Name, "foo")
+				require.Equal(pipelines[1].Name, "bar")
+			},
+		},
+
 		{
 			"pipeline_nested_pipes.hcl",
 			func(t *testing.T, c *Config) {

internal/config/testdata/pipelines/pipelines_many_many_many.hcl

@@ -0,0 +1,84 @@
+project = "foo"
+
+pipeline "foo" {
+  step "test" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+
+pipeline "bar" {
+  step "test2" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+pipeline "foofoo" {
+  step "test2" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+pipeline "barbar" {
+  step "test2" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+pipeline "foobar" {
+  step "test2" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+pipeline "naming-is-hard" {
+  step "test2" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+pipeline "hey-we-made-it" {
+  step "test2" {
+    image_url = "example.com/test"
+
+    use "exec" {
+      command = "bar"
+    }
+  }
+}
+
+app "web" {
+    config {
+        env = {
+            static = "hello"
+        }
+    }
+
+    build {}
+
+    deploy {}
+}