Protobuf comments and field order

Also looping in Rae's fix (https://github.com/hashicorp/waypoint/pull/1596/files)
hashicorp · Jun 4, 2021 · 4c3d1b4 · 4c3d1b4
1 parent 9deecd5
commit 4c3d1b4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/internal/cli/deployment_list.go b/internal/cli/deployment_list.go
@@ -113,7 +113,7 @@ func (c *DeploymentListCommand) Run(args []string) int {
 			Workspace:   wsRef,
 		})
 
-		if status.Code(err) == codes.NotFound {
+		if status.Code(err) == codes.NotFound || status.Code(err) == codes.Unimplemented{
 			err = nil
 			statusReportsResp = nil
 		}

diff --git a/internal/server/gen/server.pb.go b/internal/server/gen/server.pb.go
diff --git a/internal/server/proto/server.proto b/internal/server/proto/server.proto
@@ -2368,12 +2368,18 @@ message StatusReport {
   // This message is a StatusReport proto that exists inside the SDK
   google.protobuf.Any status_report = 7;
 
-  // The overall health of the deployment or release as reported by the plugin
+  // The overall health of the deployment or release as reported by the plugin.
+  // Copied from the plugin generated raw SDK status report for convenient API access.
   Health health = 8;
 
   // A health report of all of the resources that make up the report.
+  // Copied from the plugin generated raw SDK status report for convenient API access.
   repeated Health resources_health = 9;
 
+  // the time when this report was generated
+  // Copied from the plugin generated raw SDK status report for convenient API access.
+  google.protobuf.Timestamp generated_time = 10;
+
   message Health {
     // the overall health of the report for a resource
     string health_status = 1;
@@ -2387,9 +2393,6 @@ message StatusReport {
     // Resource id
     string id = 4;
   }
-
-  // the time when this report was generated
-  google.protobuf.Timestamp generated_time = 10;
 }
 
 /********************************************************************