Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Commit

Permalink
Unimplemented status report "Unknown Status" -> "n/a"
Browse files Browse the repository at this point in the history
Previously, if a plugin does not return status reports, we would say "Unknown Status", which is a bit wordy and also conflicts with the "UNKNOWN" official status, where a plugin _has tried_ to get status and is explicitly returning unknown.

"n/a" kind of implies that the very concept of health doesn't apply to some deployments, which isn't right either, but it's the least-worst thing I can think of.
  • Loading branch information
izaaklauer committed Jun 4, 2021
1 parent b06e9ff commit 41bd080
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/cli/deployment_list.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (c *DeploymentListCommand) Run(args []string) int {
}

// Add status report information if we have any
statusReportComplete := "Unknown Status"
statusReportComplete := "n/a"
for _, statusReport := range statusReportsResp.StatusReports {
if deploymentTargetId, ok := statusReport.TargetId.(*pb.StatusReport_DeploymentId); ok {
if deploymentTargetId.DeploymentId == b.Id {
Expand Down

0 comments on commit 41bd080

Please sign in to comment.