This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Feature: allow plugin debugging #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for debugging plugins!
evanphx
approved these changes
Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enable debugging of plugin processes with tools like Delve. It follows Terraform's model for debugging plugins, and the code is in large part copied from terraform-plugin-sdk.
See hashicorp/waypoint#1716 for how these changes would be consumed by core, and a description of the debugging workflow that this enables.
This introduces a new
Debugmethod, which a plugin can use instead ofMainto launch in an unmanaged mode and wait for core to connect.